Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.18%. Comparing base (f5d454a) to head (bda9e62).
Report is 917 commits behind head on main.

@@            Coverage Diff             @@
##             main   #55150      +/-   ##
==========================================
- Coverage   88.23%   88.18%   -0.05%     
==========================================
  Files         651      649       -2     
  Lines      183902   183327     -575     
  Branches    35855    35686     -169     
==========================================
- Hits       162269   161672     -597     
- Misses      14926    15024      +98     
+ Partials     6707     6631      -76     

From what I remember, almost all places that use/expose trace labels are susceptible to this issue, I don't remember exactly the places but I think could be something worthy to take a double look.

Fixing this implementation also fixes the console.time implementation, so if you want to include a test there too, could be useful.

Fixing this implementation also fixes the console.time implementation, so if you want to include a test there too, could be useful.

Do you have an example? Naive testing (node -e 'console.time(`test"`);console.timeEnd(`test"`)') doesn't show the issue.

CI: https://ci.nodejs.org/job/node-test-pull-request/62840/

CI: https://ci.nodejs.org/job/node-test-pull-request/62842/

@aduh95 node --trace-event-categories -e 'console.time(`test"`);console.timeEnd(`test"`)'

The generated logs are in json, and the json file is broken.

Edit2: I'm okay with adding tests in another PR (since the CI of this PR is already green)

Landed in 78f421d

Tentatively backport in #56927 to reduce conflicts. Though this is not very essential and might get dropped.

Backing it out from #56927 to avoid introducing surface for regressions.